On Thursday, July 13, 2023 at 7:07:10 AM UTC-5 Edward K. Ream wrote:

Various commands and methods create a single new node. Their undo logic can 
mimic that of undo/redo insert-node. Undoing these commands would delete 
the newly-created node. Redo would undo the delete.


All those commands relate to git-diff. On second thought, *none of them 
need to be undoable*.

Why? Because these commands create the last top-level node of the outline. 
I never want to undo the new node immediately, which is the only time an 
undo command would work!

Instead, I delete the git-related node in some distant future.

*Summary*

Not all commands need to be undoable.

I shall eliminate the undo logic for *all *commands using u.beforeChangeTree, 
and u.afterChangeTree. This policy will help Félix complete his work on 
leoJS.

I'll reconsider this choice only if it causes *practical *problems.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/leo-editor/280f6364-b3bd-4ae1-9adf-e50747536c29n%40googlegroups.com.

Reply via email to