Hi,
minor comments only. Please fix and apply directly afterwards, this is
a massive and useful patch and I want to get it out of the way.
On Mon, Apr 11, 2011 at 4:01 PM, Luca Barbato <lu_z...@gentoo.org> wrote:
> @@ -199,20 +116,14 @@ DECLARE_ASM_CONST(8, uint64_t, blue_15mask) =
> 0x0000001f0000001fULL;
> 32-bit C version, and and&add trick by Michael Niedermayer
> */
>
> +void rgb2rgb_init_x86();
> +
Please create a header file that will hold all such declarations. They
don't belong in a C file, but e.g. in libswscale/x86/rgb2rgb.h or
libswscale/rgb2rgb.h (that's how we do it in dsputil in libavcodec).
> void sws_rgb2rgb_init(int flags)
> {
> + rgb2rgb_init_c();
> #if HAVE_MMX2 || HAVE_AMD3DNOW || HAVE_MMX
This should now change to ARCH_X86. We don't vare which
implementations exist in this file.
The rest looks good. I really, really like this change, please just
commit it. There's a lot more to be done after this, and we can build
that on top of this patch.
Ronald
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
