On 04/12/2011 11:03 PM, Ronald S. Bultje wrote: > This one can use a lot more cleanup.
I know and stated on the commit message =) > Big ones: in x86/swscale_template.c, there's a bunch of #if > COMPILE_TEMPLATE_MMX. They are unnecessary, all of 3dnow/mmx/mmx2 set > COMPILE_TEMPLATE_MMX, and thus the check (+#else code) can be removed. You are probably right. > Minor ones, which you can skip until after the initial patch is applied: > - the ppc code has a lot of C code in there also. Have you confirmed > that all C code is in fact required? Is there dead code in there? If > so, can we figure out which and kill it? On a later time surely. > - several ppc (and possibly also x86) functions are prefixed with > _mmx, _mmx2, _3dnow or _altivec but in fact don't use any mmx2 (only > mmx) or even mmx/altivec (only C) instructions. Ideally, the init > system would be more like dsputil, where for these functions, we don't > duplicate two _c variants (one called _c, one called _altivec/_mmx) > and then inline everything, but instead we detect that and call the _c > version directly, or call a function pointer that is dynamically > assigned. This is complex because swscale isn't as smart as dsputil so > you can do this later. That is on part of the todo (the first patch of the next set) > Is autodetection of cpuflags working? ffmpeg had a patch and I don't > think we have it yet. If we integrate this, we should also have > cpuflag autodetection working so we can auto-enable that (at least for > x86). We could add that now I guess. lu -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
