On Thu, Apr 21, 2011 at 10:10 AM, Diego Biurrun <di...@biurrun.de> wrote: > Do not call av_log_ask_for_sample() from av_log_missing_feature() depending on > the value of a flag parameter. Instead, call av_log_ask_for_sample() directly > where this is desired. This simplifies av_log_missing_feature() and makes for > a nicer API. > --- > libavcodec/aac_adtstoasc_bsf.c | 5 +++-- > libavcodec/aacdec.c | 20 +++++++++++++------- > libavcodec/aacsbr.c | 5 +++-- > libavcodec/ac3dec.c | 3 ++- > libavcodec/alsdec.c | 2 +- > libavcodec/amrnbdec.c | 3 ++- > libavcodec/amrwbdec.c | 6 ++++-- > libavcodec/avcodec.h | 6 +----- > libavcodec/eac3dec.c | 12 ++++++++---- > libavcodec/flacdec.c | 2 +- > libavcodec/mpc8.c | 3 ++- > libavcodec/utils.c | 11 +++-------- > libavcodec/vc1.c | 2 +- > libavcodec/vp8.c | 6 ++++-- > libavcodec/wmavoice.c | 3 ++- > libavformat/rtpdec_latm.c | 8 +++++--- > libavformat/rtpdec_qt.c | 9 ++++++--- > libavformat/spdifdec.c | 5 +++-- > 18 files changed, 64 insertions(+), 47 deletions(-) > > diff --git a/libavcodec/aac_adtstoasc_bsf.c b/libavcodec/aac_adtstoasc_bsf.c > index fbb86f8..6071b5c 100644
[...] > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > index 7727ad0..e6bcc80 100644 > --- a/libavcodec/avcodec.h > +++ b/libavcodec/avcodec.h > @@ -4097,12 +4097,8 @@ unsigned int av_xiphlacing(unsigned char *s, unsigned > int v); > * @param[in] avc a pointer to an arbitrary struct of which the first field is > * a pointer to an AVClass struct > * @param[in] feature string containing the name of the missing feature > - * @param[in] want_sample indicates if samples are wanted which exhibit this > feature. > - * If want_sample is non-zero, additional verbage will be added to the log > - * message which tells the user how to report samples to the development > - * mailing list. > */ > -void av_log_missing_feature(void *avc, const char *feature, int want_sample); > +void av_log_missing_feature(void *avc, const char *feature); > > /** > * Log a generic warning message asking for a sample. This function is [...] This is a public header. _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
