Hi,

On Tue, Apr 26, 2011 at 2:07 PM, Diego Biurrun <di...@biurrun.de> wrote:
> diff --git a/libavutil/bswap.h b/libavutil/bswap.h
[..]
> -#if 0
> -    x= ((x<< 8)&0xFF00FF00FF00FF00ULL) | ((x>> 8)&0x00FF00FF00FF00FFULL);
> -    x= ((x<<16)&0xFFFF0000FFFF0000ULL) | ((x>>16)&0x0000FFFF0000FFFFULL);
> -    return (x>>32) | (x<<32);
> -#else
[..]
> -#endif

OK.

> diff --git a/libavutil/mathematics.c b/libavutil/mathematics.c
[..]
> -#if 1
>         uint64_t a0= a&0xFFFFFFFF;
>         uint64_t a1= a>>32;
>         uint64_t b0= b&0xFFFFFFFF;
> @@ -116,14 +115,6 @@ int64_t av_rescale_rnd(int64_t a, int64_t b, int64_t c, 
> enum AVRounding rnd){
>         }
>         return t1;
>     }
> -#else
> -        AVInteger ai;
> -        ai= av_mul_i(av_int2i(a), av_int2i(b));
> -        ai= av_add_i(ai, av_int2i(r));
> -
> -        return av_i2int(av_div_i(ai, av_int2i(c)));
> -    }
> -#endif

Please leave this in, it serves as poor man's documentation for what
the function is doing if it wasn't for overflows or stuff like that.

Can't speak for softfloat since I don't understand that code.

Ronald
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to