On date Monday 2011-05-30 23:12:53 +0200, Anton Khirnov encoded: > On Mon, 30 May 2011 22:18:31 +0200, Stefano Sabatini > <[email protected]> wrote: [...] > > > +const AVOption *avopt_find(void *obj, const char *name, const char *unit, > > > + int opt_flags, int search_flags); > > > > Namescheme: av_opt_find() looks better (consistent with the av_opt_ > > scheme), I'm not sure this is meant as a general replacement for > > av_find_opt() though. > > Yes it is, av_find_opt is meant to be deprecated. > As for the naming bikeshed, avopt_* namespace is consistent with avcodec_, > avformat_, avfilter_, avio_ etc. It also saves you one character ;)
Note that FF^H^Hlibav* is pretty inconsistent in this regard (avio_, avcodec_, avfilter_, *but* av_img_, av_eval, av_file_, av_crc_, same for constants, we have AV_OPT_, AV_CPU_..., AV_SAMPLE_FMT_, AV_CH_... *but* AVMEDIA_TYPE_, AVDISCARD_, AVCOL_). I tend to prefer the av_ variant since it looks more readable to me, in the case of AVOptions I see there are already some functions which start with av_opt_ so I was thinking to keep that scheme. -- No shirt, no shoes, no service. _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
