Hi, On Mon, May 30, 2011 at 2:12 PM, Anton Khirnov <[email protected]> wrote: > On Mon, 30 May 2011 22:18:31 +0200, Stefano Sabatini > <[email protected]> wrote: >> On date Monday 2011-05-30 21:15:20 +0200, Anton Khirnov encoded: >> > + * >> > + * @param[in] obj A pointer to a struct whose first element is a >> > + * pointer to an AVClass. >> > + * @param[in] name The name of the option to look for. >> > + * @param[in] unit When searching for named constants, name of the unit >> > + * it belongs to. >> > + * @param opt_flags Find only options with those flags set (AV_OPT_FLAG). >> > + * @param search_flags A combination of AVOPT_SEARCH_*. >> > + * >> > + * @return A pointer to the option found, or NULL if no option >> > + * has been found. >> > + */ >> > +const AVOption *avopt_find(void *obj, const char *name, const char *unit, >> > + int opt_flags, int search_flags); >> >> Namescheme: av_opt_find() looks better (consistent with the av_opt_ >> scheme), I'm not sure this is meant as a general replacement for >> av_find_opt() though. > > Yes it is, av_find_opt is meant to be deprecated.
(Id' expect it to be called av_find_opt2() then. :-) ) > As for the naming bikeshed, avopt_* namespace is consistent with avcodec_, > avformat_, avfilter_, avio_ etc. It also saves you one character ;) Agreed. If this is all we can come up with to block this patch, let's commit it. As long as we're consistent. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
