Diego Biurrun <[email protected]> writes: > On Sun, Jun 05, 2011 at 02:56:08AM +0100, Måns Rullgård wrote: >> Diego Biurrun <[email protected]> writes: >> >> > --- >> > libavutil/internal.h | 2 -- >> > 1 files changed, 0 insertions(+), 2 deletions(-) >> > >> > diff --git a/libavutil/internal.h b/libavutil/internal.h >> > index 51e449d..ee11a0a 100644 >> > --- a/libavutil/internal.h >> > +++ b/libavutil/internal.h >> > @@ -141,7 +141,6 @@ >> > #define strncpy strncpy_is_forbidden_due_to_security_issues_use_av_strlcpy >> > #undef exit >> > #define exit exit_is_forbidden >> > -#ifndef LIBAVFORMAT_BUILD >> > #undef printf >> > #define printf please_use_av_log_instead_of_printf >> > #undef fprintf >> > @@ -150,7 +149,6 @@ >> > #define puts please_use_av_log_instead_of_puts >> > #undef perror >> > #define perror please_use_av_log_instead_of_perror >> > -#endif >> >> I'm pretty sure those were there for a reason. Please find out and make >> sure that reason is gone. > > They were added by Michael in d705e4a6bb6d052f4054886511bf0adb518d72c4 > to avoid (f)printf getting used in libavcodec. Back then libavformat > apparently did not fall under this rule yet.
You're right, there's no reason for that anymore. Patch OK. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
