On Sun, Jun 05, 2011 at 11:49:22AM +0100, Måns Rullgård wrote:
> Diego Biurrun <[email protected]> writes:
> 
> > On Sun, Jun 05, 2011 at 02:54:10AM +0100, Måns Rullgård wrote:
> >> Diego Biurrun <[email protected]> writes:
> >> 
> >> > diff --git a/libavcodec/aac_tablegen.h b/libavcodec/aac_tablegen.h
> >> > index 4486e1a..ab1bdb3 100644
> >> > --- a/libavcodec/aac_tablegen.h
> >> > +++ b/libavcodec/aac_tablegen.h
> >> > @@ -26,10 +26,10 @@
> >> >  #include "aac_tablegen_decl.h"
> >> >  
> >> >  #if CONFIG_HARDCODED_TABLES
> >> > -#include "libavcodec/aac_tables.h"
> >> > +#include "aac_tables.h"
> >> >  #else
> >> >  #include "libavutil/mathematics.h"
> >> > -#include "libavcodec/aac.h"
> >> > +#include "aac.h"
> >> >  float ff_aac_pow2sf_tab[428];
> >> 
> >> This and others like it will not work with hardcoded tables.
> >
> > How would it fail?  I ran 'make all fate checkheaders' w/ and w/o
> > hardcoded tables enabled, all is fine.  Plus, the generated headers
> > are identical before and after the change.
> 
> Run a plain old make outside the source tree with hardcoded tables enabled.

Doh, of course - generated headers are placed in the build tree, not the
source tree.  Updated patch coming up in a sec...

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to