Diego Biurrun <[email protected]> writes: > On Sun, Jun 05, 2011 at 02:55:07AM +0100, Måns Rullgård wrote: >> Diego Biurrun <[email protected]> writes: >> >> > This fixes 'make checkheaders'. >> > --- >> > libavcodec/tableprint.h | 2 ++ >> > 1 files changed, 2 insertions(+), 0 deletions(-) >> > >> > diff --git a/libavcodec/tableprint.h b/libavcodec/tableprint.h >> > index ddf2635..27d5b50 100644 >> > --- a/libavcodec/tableprint.h >> > +++ b/libavcodec/tableprint.h >> > @@ -28,6 +28,8 @@ >> > >> > #include "libavutil/common.h" >> > >> > +#undef printf >> >> The commit message is weird. The change has no effect on checkheaders. > > It does because tableprint.h uses printf: > > libavcodec/tableprint.h:94:1: error: implicit declaration of function > ‘please_use_av_log_instead_of_printf’ [-Werror=implicit-function-declaration]
tableprint.h should not be part of the regular checkheaders since it is only built for the host, not the target. It is perfectly reasonable for this header not to compile for the target at all. Please add it to SKIPHEADERS. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
