On Tue, Jun 07, 2011 at 11:52:36AM -0400, Ronald S. Bultje wrote: > > On Tue, Jun 7, 2011 at 11:42 AM, John Stebbins <[email protected]> > wrote: > > On 06/07/2011 07:49 AM, Ronald S. Bultje wrote: > >> > >> My apologies. I was wondering if this triggers for all vc1 files, or > >> just wvp2/wmvp ones (this is where read_sequence_header sets size, > >> IIRC). Alternatively, maybe we can compare w/h before and after > >> read_sequence_header so we don't needlessly reinitialize (it is quite > >> heavy, so prefer to prevent it if not necessary). > >> > >> But the idea of the patch is good, I'm OK with applying it with the > >> above reoslved. > > > > read_sequence_header is called in all cases through vc1_decode_init. In all > > cases, it is pulling the sequence header information out of extradata which > > must be initialized by the caller before doing avcodec_open. I have only > > tested the vc1/wvc1/wvp2 path, but it's obvious by inspecting the code that > > it is always called. > > > > Here's an updated patch that only re-initializes if w/h changes. > > Thanks, LGTM.
Could somebody provide a git-formatted patch or a log message so we can push this more easily? Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
