Hi, On Wed, Jun 15, 2011 at 10:51 AM, Diego Biurrun <[email protected]> wrote: > On Tue, Jun 07, 2011 at 11:52:36AM -0400, Ronald S. Bultje wrote: >> >> On Tue, Jun 7, 2011 at 11:42 AM, John Stebbins <[email protected]> >> wrote: >> > On 06/07/2011 07:49 AM, Ronald S. Bultje wrote: >> >> >> >> My apologies. I was wondering if this triggers for all vc1 files, or >> >> just wvp2/wmvp ones (this is where read_sequence_header sets size, >> >> IIRC). Alternatively, maybe we can compare w/h before and after >> >> read_sequence_header so we don't needlessly reinitialize (it is quite >> >> heavy, so prefer to prevent it if not necessary). >> >> >> >> But the idea of the patch is good, I'm OK with applying it with the >> >> above reoslved. >> > >> > read_sequence_header is called in all cases through vc1_decode_init. In >> > all >> > cases, it is pulling the sequence header information out of extradata which >> > must be initialized by the caller before doing avcodec_open. I have only >> > tested the vc1/wvc1/wvp2 path, but it's obvious by inspecting the code that >> > it is always called. >> > >> > Here's an updated patch that only re-initializes if w/h changes. >> >> Thanks, LGTM. > > Could somebody provide a git-formatted patch or a log message so we > can push this more easily?
This was already pushed. commit 7b20d35a543c6635c348f3b312b5fa24137c0f95 Author: John Stebbins <[email protected]> Date: Tue Jun 7 19:53:31 2011 +0200 vc1: re-initialize tables after width/height change. read_sequence_header can change width/height; therefore, re-initialize all tables if width/height changed Signed-off-by: Anton Khirnov <[email protected]> Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
