Hi, On Tue, Sep 27, 2011 at 9:52 PM, Kieran Kunhya <kier...@ob-encoder.com> wrote: >> Please don't use hardcoded function names, use function pointers (the >> interleavedX one) instead. Also, I think at this point it makes sense >> to split the luma/chroma path already so that we choose for chroma and >> luma separately whether to use _1 or _X functions (and then for >> chroma, whether to use interleaved or plane). > > Can you clarify what you mean here? As far as I can see yuv2nv12X is called in > exactly the same way as all the other functions.
Right, so yuv2yuvX used to do this: for (x=0;x<n;x++) luma for (x=0;x<n;x++) chroma1 chroma2 for (x=0;x<n;x++) alpha you rightfully changed this to: for (x=0;x<n;x++) plane Now take nv12x, which does: for (n=0;n<x;n++) luma for (n=0;n<x;n++) chromamixed I want you to use the existing new changed plane function for luma, so that only the chroma mixed is a special case. Ronald _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel