Hi,

On Fri, Sep 30, 2011 at 6:11 PM, Kieran Kunhya <kier...@ob-encoder.com> wrote:
> /me blames gmail

Nice stuff, mostly OK. Small comments:

> +    yuv2planarX_fn yuv2plane_luma;
> +    yuv2planarX_fn yuv2plane_chroma;
> +    yuv2interleavedX_fn yuv2nv12X;

To remain consistent with the X/1 suffix model, I'd call the first two
yuv2planeX_luma/chroma. The last one only handles chroma and you could
thus volunteer to call it yuv2nv12X_chroma.

Shouldn't the patch comment out the SIMD yuv2yuvX functions (x86 and ppc)?

Ronald
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to