Diego Biurrun <[email protected]> writes:

> On Thu, Sep 29, 2011 at 12:07:41PM +0100, Måns Rullgård wrote:
>> Diego Biurrun <[email protected]> writes:
>> > On Thu, Sep 29, 2011 at 11:46:26AM +0100, Måns Rullgård wrote:
>> >> Kostya Shishkov <[email protected]> writes:
>> >> > On Wed, Sep 28, 2011 at 09:52:26PM +0100, Mans Rullgard wrote:
>> >> >> +            int8x8_fmul_int32(subband_samples[k][l],
>> >> >> +                          
>> >> >> &high_freq_vq[s->high_freq_vq[k][l]][subsubframe * 8],
>> >> >> +                          s->scale_factor[k][l][0]);
>> >> >
>> >> > some Diego might complain about identation here
>> >> 
>> >> This looked more sane than all other alternatives.
>> >
>> > more sane than
>> >
>> >   int8x8_fmul_int32(subband_samples[k][l],
>> >                     &high_freq_vq[s->high_freq_vq[k][l]][subsubframe * 8],
>> >                     s->scale_factor[k][l][0]);
>> 
>> Look at the context.  At the indentation level of the block it's in,
>> that would push the longer line over 80 columns.
>
> I can live with that, better in fact, than with the non-standard and
> arguably messed-up indentation.

That's because you're not the one reading the code.

-- 
Måns Rullgård
[email protected]
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to