On Sat, Oct 22, 2011 at 03:17:08PM +0200, Michael Karcher wrote:
> Am Samstag, den 22.10.2011, 15:02 +0200 schrieb Diego Biurrun:
> > > @@ -62,7 +62,7 @@ typedef struct ID3v2ExtraMetaGEOB {
> > > /**
> > > * Detect ID3v2 Header.
> > > * @param buf must be ID3v2_HEADER_SIZE byte long
> > > - * @param magic magic bytes to identify the header, machine byte order.
> > > + * @param magic magic bytes to identify the header.
> > > * If in doubt, use ID3v2_DEFAULT_MAGIC.
> > > */
> > > int ff_id3v2_match(const uint8_t *buf, const char *magic);
> > This seems unrelated.
>
> This is right. Still this should be fixed. It's a leftover from a
> different design of that function when the magic was passed as 32 bit
> value instead of pointer-to-char (when I designed the code initially).
> Should I submit a separate patch for that single line instead?
> "machine byte order" does not make any sense for character arrays.
Yes, please don't ever group unrelated changes together in one commit.
Send the change separately, I'll push it right away.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
