Hi,
Looks great. Mans or Diego should comment on the build system stuff.
I'll test the updated version tomorrow.
On 10/25/2011 09:59 PM, Luca Barbato wrote:
> It currently use the simple api and is using the latency information
> provided only to offset the stream start.
[...]
> + pd->pts += frame_duration;
> +
> + pkt->pts = pd->pts;
Shouldn't it set pts before incrementing?
[...]
> +static const AVOption options[] = {
> + { "server", "pulse server name",
> + OFFSET(server), AV_OPT_TYPE_STRING, {.str = NULL}, 0, 0,
> D },
> + { "name", "application name",
> + OFFSET(name), AV_OPT_TYPE_STRING, {.str = "libav"}, 0, 0,
> D },
> + { "stream_name", "stream description",
> + OFFSET(stream_name), AV_OPT_TYPE_STRING, {.str = "record"}, 0, 0,
> D },
> + { "sample_rate", "",
> + OFFSET(sample_rate), AV_OPT_TYPE_INT, {.dbl = 48000}, 1,
> INT_MAX, D },
> + { "channels", "",
> + OFFSET(channels), AV_OPT_TYPE_INT, {.dbl = 2}, 1,
> INT_MAX, D },
> + { "frame_size", "",
> + OFFSET(frame_size), AV_OPT_TYPE_INT, {.dbl = 1024}, 1,
> INT_MAX, D },
> + { "fragment_size", "buffering size, affects latency and cpu usage",
> + OFFSET(fragment_size), AV_OPT_TYPE_INT, {.dbl = -1}, -1,
> INT_MAX, D },
> + { NULL },
> +};
It's easier to read these if you don't break the lines.
-Justin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
