On Wed, Oct 26, 2011 at 12:17:14AM -0700, Luca Barbato wrote:
> 
> --- a/Changelog
> +++ b/Changelog
> @@ -55,7 +55,7 @@ easier to use. The changes are:
>  - Ut Video decoder
>  - Speex encoding via libspeex
>  - 4:2:2 H.264 decoding support
> -
> +- Pulseaudio input device
>  
>  version 0.7:

Keep the extra empty line.

> --- /dev/null
> +++ b/libavdevice/pulse.c
> @@ -0,0 +1,192 @@
> +
> +/**
> + * @file
> + * Pulseaudio input
> + * @author Luca Barbato <[email protected]>
> + *
> + * This avdevice decoder allows to capture audio from a Pulseaudio device 
> using
> + * the simple api.
> + */

Both descriptions are kind of redundant.  I'd just use the first line
and write:

  PulseAudio input using the simple API.

> +    pd->s = pa_simple_new(pd->server, pd->name,
> +                      PA_STREAM_RECORD,
> +                      device, pd->stream_name, &ss,
> +                      NULL, &attr, &ret);

Indentation is off.

> +    uint64_t frame_duration =
> +        (pd->frame_size*1000000LL)/(pd->sample_rate * pd->channels);

nit: spaces around /

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to