On Sun, Oct 30, 2011 at 10:08 PM, Diego Biurrun <[email protected]> wrote:
> ---
>  cmdutils.h                |    2 +-
>  libavcodec/cinepak.c      |    7 ++++---
>  libavcodec/eamad.c        |    4 ++--
>  libavcodec/lsp.c          |    2 +-
>  libavdevice/pulse.c       |    1 -
>  libavdevice/x11grab.c     |    5 +++--
>  libavformat/matroskadec.c |    8 ++++----
>  libavformat/oggdec.c      |    5 ++---
>  8 files changed, 17 insertions(+), 17 deletions(-)
>
> diff --git a/cmdutils.h b/cmdutils.h
> index 80b20b8..77a0770 100644
> --- a/cmdutils.h
> +++ b/cmdutils.h
> @@ -190,7 +190,7 @@ void parse_loglevel(int argc, char **argv, const 
> OptionDef *options);
>  *
>  * @param s  Corresponding format context.
>  * @param st Stream from s to be checked.
> - * @param spec A stream specifier of the [v|a|s|d]:[<stream index>] form.
> + * @param spec A stream specifier of the [v|a|s|d]:[\<stream index\>] form.
>  *

Why that change?
http://libav.org/doxygen/master/cmdutils_8h.html#a632b71e4b56c5ee8556a407bbecbcef8
doesn't look broken to me at all.

Besides, while that documentation explains the format of the string to
be passed, it still leaves me the following questions:

 - what's the meaning of the v, a, s and d prefixes?
 - what happens if the string couldn't be parsed (I /guess/ the
function returns some negative value)

>  * @return 1 if the stream matches, 0 if it doesn't, <0 on error
>  */
> diff --git a/libavcodec/cinepak.c b/libavcodec/cinepak.c
> index c5d47be..fbb2c43 100644
> --- a/libavcodec/cinepak.c
> +++ b/libavcodec/cinepak.c
> @@ -22,10 +22,11 @@
>  /**
>  * @file
>  * Cinepak video decoder
> - * by Ewald Snel <[email protected]>
> - * For more information on the Cinepak algorithm, visit:
> + * @author Ewald Snel <[email protected]>
> + *
> + * @see For more information on the Cinepak algorithm, visit:
>  *   http://www.csse.monash.edu.au/~timf/
> - * For more information on the quirky data inside Sega FILM/CPK files, visit:
> + * @see For more information on the quirky data inside Sega FILM/CPK files, 
> visit:
>  *   http://wiki.multimedia.cx/index.php?title=Sega_FILM
>  */
>
> diff --git a/libavcodec/eamad.c b/libavcodec/eamad.c
> index 772fb28..c5aa6ac 100644
> --- a/libavcodec/eamad.c
> +++ b/libavcodec/eamad.c
> @@ -22,9 +22,9 @@
>  /**
>  * @file
>  * Electronic Arts Madcow Video Decoder
> - * by Peter Ross <[email protected]>
> + * @author Peter Ross <[email protected]>
>  *
> - * Technical details here:
> + * @see technical details at
>  * http://wiki.multimedia.cx/index.php?title=Electronic_Arts_MAD
>  */
>
> diff --git a/libavcodec/lsp.c b/libavcodec/lsp.c
> index 834346b..2adc9cf 100644
> --- a/libavcodec/lsp.c
> +++ b/libavcodec/lsp.c
> @@ -75,7 +75,7 @@ void ff_acelp_lsf2lspd(double *lsp, const float *lsf, int 
> lp_order)
>
>  /**
>  * @brief decodes polynomial coefficients from LSP
> - * @param f [out] decoded polynomial coefficients (-0x20000000 <= (3.22) <= 
> 0x1fffffff)
> + * @param[out] f decoded polynomial coefficients (-0x20000000 <= (3.22) <= 
> 0x1fffffff)
>  * @param lsp LSP coefficients (-0x8000 <= (0.15) <= 0x7fff)
>  */
>  static void lsp2poly(int* f, const int16_t* lsp, int lp_half_order)
> diff --git a/libavdevice/pulse.c b/libavdevice/pulse.c
> index 1edd24f..80c48d0 100644
> --- a/libavdevice/pulse.c
> +++ b/libavdevice/pulse.c
> @@ -23,7 +23,6 @@
>  * @file
>  * PulseAudio input using the simple API.
>  * @author Luca Barbato <[email protected]>
> - *
>  */
>
>  #include <pulse/simple.h>
> diff --git a/libavdevice/x11grab.c b/libavdevice/x11grab.c
> index 7874b81..7e2aee7 100644
> --- a/libavdevice/x11grab.c
> +++ b/libavdevice/x11grab.c
> @@ -31,8 +31,9 @@
>
>  /**
>  * @file
> - * X11 frame device demuxer by Clemens Fruhwirth <[email protected]>
> - * and Edouard Gomez <[email protected]>.
> + * X11 frame device demuxer
> + * @author Clemens Fruhwirth <[email protected]>
> + * @author Edouard Gomez <[email protected]>
>  */
>
>  #include "config.h"
> diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c
> index 3f48a72..18231fe 100644
> --- a/libavformat/matroskadec.c
> +++ b/libavformat/matroskadec.c
> @@ -22,10 +22,10 @@
>  /**
>  * @file
>  * Matroska file demuxer
> - * by Ronald Bultje <[email protected]>
> - * with a little help from Moritz Bunkus <[email protected]>
> - * totally reworked by Aurelien Jacobs <[email protected]>
> - * Specs available on the Matroska project page: http://www.matroska.org/.
> + * @author Ronald Bultje <[email protected]>
> + * @author with a little help from Moritz Bunkus <[email protected]>
> + * @author totally reworked by Aurelien Jacobs <[email protected]>
> + * @see specs available on the Matroska project page: 
> http://www.matroska.org/
>  */
>
>  #include <stdio.h>
> diff --git a/libavformat/oggdec.c b/libavformat/oggdec.c
> index f7513cf..aaf3468 100644
> --- a/libavformat/oggdec.c
> +++ b/libavformat/oggdec.c
> @@ -2,10 +2,9 @@
>  * Ogg bitstream support
>  * Luca Barbato <[email protected]>
>  * Based on tcvp implementation
> - *
>  */
>
> -/**
> +/*
>     Copyright (C) 2005  Michael Ahlberg, Måns Rullgård
>
>     Permission is hereby granted, free of charge, to any person
> @@ -27,7 +26,7 @@
>     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
>     OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>     DEALINGS IN THE SOFTWARE.
> -**/
> + */

Rest is OK, I guess.

-- 
regards,
    Reinhard
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to