On Tue, Nov 08, 2011 at 02:35:57PM +0100, Kostya Shishkov wrote:
> On Sun, Oct 30, 2011 at 10:08:47PM +0100, Diego Biurrun wrote:
> > Filenames are brittle across renames and add no useful information.
> > 
> > --- a/libavcodec/arm/simple_idct_arm.S
> > +++ b/libavcodec/arm/simple_idct_arm.S
> > @@ -1,5 +1,4 @@
> >  /*
> > - * simple_idct_arm.S
> 
> 'twould be nice to have a description here

If wishes were fishes, we'd all cast nets :)

> > --- a/libavcodec/jfdctfst.c
> > +++ b/libavcodec/jfdctfst.c
> > @@ -1,6 +1,4 @@
> >  /*
> > - * jfdctfst.c
> > - *
> >   * This file is part of the Independent JPEG Group's software.
> >   *
> >   * The authors make NO WARRANTY or representation, either express or 
> > implied,
> > --- a/libavcodec/jfdctint_template.c
> > +++ b/libavcodec/jfdctint_template.c
> > @@ -1,6 +1,4 @@
> >  /*
> > - * jfdctint.c
> > - *
> 
> and here
> 
> >   * This file is part of the Independent JPEG Group's software.
> >   *
> >   * The authors make NO WARRANTY or representation, either express or 
> > implied,
> > --- a/libavcodec/jrevdct.c
> > +++ b/libavcodec/jrevdct.c
> > @@ -1,6 +1,4 @@
> >  /*
> > - * jrevdct.c
> > - *
> 
> and here, or maybe not touch those two files at all - they are not ours
> 
> > --- a/libavcodec/x86/idct_mmx.c
> > +++ b/libavcodec/x86/idct_mmx.c
> > @@ -1,5 +1,4 @@
> >  /*
> > - * idct_mmx.c
> >   * Copyright (C) 1999-2001 Aaron Holtzman <[email protected]>
> >   *
> >   * This file is part of mpeg2dec, a free MPEG-2 video stream decoder.
> 
> I wouldn't touch this file too, the rest look fine though.

I'll go out on a limb here, assume it's harmless (enough) and push with
Mans' blessing.  Thanks for reviewing.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to