On 2011-12-21 14:07:43 +0000, Måns Rullgård wrote: > Benjamin Larsson <benja...@southpole.se> writes: > > > On 12/20/2011 05:43 PM, Janne Grunau wrote: > >> Hi, > >> > >> applied mostly as they are in FFmpeg. I've cleaned some commit > >> messages, changed memory alloction from the pointless av_calloc > >> to av_mallocz, fixed potential memleaks on allocation errors. > >> > >> Janne > > > > All in all the set looks good. But lots of index code is added and > > removed. Those changes could be squashed but I'm slightly more in > > favor of committing as is to preserve history. > > What's the point in preserving history that doesn't work? By extension, > we should preserve every save of every file by any developer. After > all, those are all part of the history. I'm sure you agree that would > be insane.
I've squashed it and the single commit looks much better than current series of patches. Janne _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
