On Mon, Jun 18, 2012 at 04:48:43PM +0300, Martin Storsjö wrote:
> >diff --git a/libavcodec/mss1.c b/libavcodec/mss1.c
> >new file mode 100644
> >index 0000000..ba1a613
> >--- /dev/null
> >+++ b/libavcodec/mss1.c
> >@@ -0,0 +1,846 @@
> >+/*
> >+ * Microsoft Screen 1 (aka Windows Media Video V7 Screen) decoder
> >+ * Copyright (c) 2012 Konstantin Shishkov
> >+ *
> >+ * This file is part of Libav.
> >+ *
> >+ * Libav is free software; you can redistribute it and/or
> >+ * modify it under the terms of the GNU Lesser General Public
> >+ * License as published by the Free Software Foundation; either
> >+ * version 2.1 of the License, or (at your option) any later version.
> >+ *
> >+ * Libav is distributed in the hope that it will be useful,
> >+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
> >+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> >+ * Lesser General Public License for more details.
> >+ *
> >+ * You should have received a copy of the GNU Lesser General Public
> >+ * License along with Libav; if not, write to the Free Software
> >+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
> >USA
> >+ */
> >+
> >+/**
> >+ * @file
> >+ * Microsoft Screen 1 (aka Windows Media Video V7 Screen) decoder
> >+ */
> >+
> >+#include "libavutil/intfloat.h"
> >+#include "libavutil/intreadwrite.h"
> >+#include "avcodec.h"
> >+#include "get_bits.h"
> >+
> >+enum SplitMode {
> >+ SPLIT_VERT = 0,
> >+ SPLIT_HOR,
> >+ SPLIT_NONE
> >+};
> >+
> >+typedef struct ArithCoder {
> >+ int low, high, value;
> >+ GetBitContext *gb;
> >+} ArithCoder;
> >+
> >+#define MODEL_MIN_SYMS 2
> >+#define MODEL_MAX_SYMS 256
> >+#define THRESH_ADAPTIVE -1
> >+#define THRESH_LOW 15
> >+#define THRESH_HIGH 50
> >+#define THRESH_KOSTYA 1986
>
> Nice easter egg ;P (aka unused define)
Indeed it's wrong (should be 1985 instead).
> I didn't find anything objectionable in the rest of the patch, but
> I'm not very familiar with this kind of code, so my review perhaps
> isn't the most valuable one.
Well, the code is rather simple. And any review is better than the lack of
them.
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
