>>> diff --git a/libavutil/avutil.h b/libavutil/avutil.h
>>> index 351e827..2aae161 100644
>>> --- a/libavutil/avutil.h
>>> +++ b/libavutil/avutil.h
>>> @@ -152,7 +152,7 @@
>>> */
>>>
>>> #define LIBAVUTIL_VERSION_MAJOR 51
>>> -#define LIBAVUTIL_VERSION_MINOR 34
>>> +#define LIBAVUTIL_VERSION_MINOR 0
>>> #define LIBAVUTIL_VERSION_MICRO 0
>
>
> This doesn't look right
Oh my bad, I'm really sorry, I don't understand why I did that weird change...
>
>
>>> +static const uint32_t orig_s[4][256] = {
>>> + { 0xD1310BA6u, 0x98DFB5ACu, 0x2FFD72DBu, 0xD01ADFB7u,
>>> + 0xB8E1AFEDu, 0x6A267E96u, 0xBA7C9045u, 0xF12C7F99u,
>
>
> Kostya had a comment about the formatting of this, which you didn't take
> into account, and you didn't reply to his comment either, saying why you
> chose not to take it into account.
Indeed, I forgot to change that.
>
>
>>> diff --git a/libavutil/blowfish.h b/libavutil/blowfish.h
>>> new file mode 100644
>>> index 0000000..91d00a3
>>> --- /dev/null
>>> +++ b/libavutil/blowfish.h
>>> @@ -0,0 +1,60 @@
>>> +/*
>>> + * Blowfish algorithm
>>> + *
>>> + * This file is part of Libav.
>>> + *
>>> + * Libav is free software; you can redistribute it and/or
>>> + * modify it under the terms of the GNU Lesser General Public
>>> + * License as published by the Free Software Foundation; either
>>> + * version 2.1 of the License, or (at your option) any later version.
>>> + *
>>> + * Libav is distributed in the hope that it will be useful,
>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
>>> + * Lesser General Public License for more details.
>>> + *
>>> + * You should have received a copy of the GNU Lesser General Public
>>> + * License along with Libav; if not, write to the Free Software
>>> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
>>> 02110-1301 USA
>>> + */
>>> +
>>> +#ifndef AVUTIL_BF_H
>>> +#define AVUTIL_BF_H
>
>
> Make sure this matches the file name
Okay.
> When replying to a long email, it's advisable to trim out the irrelevant
> parts of the quoted email, so that readers won't have to scroll through 40
> KB of tables to find what you actually replied to.
It's still a bad habit... I'll try to think about that the next time.
--
Best regards,
Samuel Pitoiset.
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
