On Sun, Jul 01, 2012 at 12:35:34PM +0200, Samuel Pitoiset wrote:
> > +static void F(AVBlowfish *bf, uint32_t *xl, uint32_t *xr, int i)
> > +{
> > + uint32_t Xl, Xr;
> > + uint32_t y;
> > +
> > + Xl = *xl;
> > + Xr = *xr;
> > +
> > + Xl ^= bf->p[i];
> > + y = bf->s[0][(Xl >> 24) & 0xFF];
> > + y += bf->s[1][(Xl >> 16) & 0xFF];
> > + y ^= bf->s[2][(Xl >> 8) & 0xFF];
> > + y += bf->s[3][ Xl & 0xFF];
> > + Xr ^= y;
> > +
> > + FFSWAP(uint32_t, Xl, Xr);
>
> I think this FFSWAP call is pointless too, right?
>
> > +
> > + *xl = Xl;
> > + *xr = Xr;
> > +}
In this case - yes, you can simply assign output properly.
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
