Diego Biurrun <di...@biurrun.de> writes: > On Tue, Aug 28, 2012 at 04:17:46PM +0100, Måns Rullgård wrote: >> Diego Biurrun <di...@biurrun.de> writes: >> > On Tue, Aug 28, 2012 at 01:54:57PM +0100, Måns Rullgård wrote: >> >> Diego Biurrun <di...@biurrun.de> writes: >> >> > --- a/libavfilter/x86/gradfun.c >> >> > +++ b/libavfilter/x86/gradfun.c >> >> > @@ -24,12 +24,10 @@ >> >> > #include "libavutil/x86/asm.h" >> >> > #include "libavfilter/gradfun.h" >> >> > >> >> > -#if HAVE_INLINE_ASM >> >> >> >> Why do you remove that line? >> > >> > I'm replacing HAVE_FOO below with HAVE_INLINE_FOO, which already >> > ensures that HAVE_INLINE_ASM is set. >> >> But now you're defining those constants even if it's not enabled. > > So?
So it's wrong. > It does not even generate warnings... That's because the warning is silenced by a 'used' attribute. -- Måns Rullgård m...@mansr.com _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
