Diego Biurrun <di...@biurrun.de> writes:
> ---
>
> This is coming along nicely, the patch is much smaller than before.
> Now incorporating almost all review comments.
>
> configure | 33 ++++++++++++++++++++++++++++-----
> libavfilter/x86/gradfun.c | 23 ++++++++---------------
> libavfilter/x86/yadif.c | 24 ++++++------------------
> libavutil/x86/float_dsp_init.c | 6 ++----
> 4 files changed, 44 insertions(+), 42 deletions(-)
>
> diff --git a/configure b/configure
> index 3b5a110..08dca14 100755
> --- a/configure
> +++ b/configure
> @@ -629,6 +629,12 @@ add_host_ldflags(){
> append host_ldflags $($host_ldflags_filter "$@")
> }
>
> +add_suffix(){
> + suffix=$1
> + shift
> + for v; do echo ${v}${suffix}; done
> +}
Please put this function next to the other general text processing
functions like filter() and map().
> check_cmd(){
> log "$@"
> "$@" >> $logfile 2>&1
> @@ -1098,8 +1104,13 @@ HAVE_LIST_PUB='
> fast_unaligned
> '
>
> +ARCH_EXT_LIST_X86_EXTERNAL=$(add_suffix _external $ARCH_EXT_LIST_X86)
> +ARCH_EXT_LIST_X86_INLINE=$(add_suffix _inline $ARCH_EXT_LIST_X86)
You lost the definition of ARCH_EXT_LIST_X86.
> diff --git a/libavfilter/x86/gradfun.c b/libavfilter/x86/gradfun.c
> index e7890fe..82c09e3 100644
> --- a/libavfilter/x86/gradfun.c
> +++ b/libavfilter/x86/gradfun.c
> @@ -24,12 +24,10 @@
> #include "libavutil/x86/asm.h"
> #include "libavfilter/gradfun.h"
>
> -#if HAVE_INLINE_ASM
> -
> DECLARE_ALIGNED(16, static const uint16_t, pw_7f)[8] =
> {0x7F,0x7F,0x7F,0x7F,0x7F,0x7F,0x7F,0x7F};
> DECLARE_ALIGNED(16, static const uint16_t, pw_ff)[8] =
> {0xFF,0xFF,0xFF,0xFF,0xFF,0xFF,0xFF,0xFF};
You're now defining these constants even when they are not used. Don't.
[...]
> diff --git a/libavfilter/x86/yadif.c b/libavfilter/x86/yadif.c
> index 0907a50..873c415 100644
> --- a/libavfilter/x86/yadif.c
> +++ b/libavfilter/x86/yadif.c
> @@ -26,12 +26,10 @@
> #include "libavcodec/x86/dsputil_mmx.h"
> #include "libavfilter/yadif.h"
>
> -#if HAVE_INLINE_ASM
> -
> DECLARE_ASM_CONST(16, const xmm_reg, pb_1) = {0x0101010101010101ULL,
> 0x0101010101010101ULL};
> DECLARE_ASM_CONST(16, const xmm_reg, pw_1) = {0x0001000100010001ULL,
> 0x0001000100010001ULL};
Ditto.
--
Måns Rullgård
m...@mansr.com
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
