Diego Biurrun <di...@biurrun.de> writes: > On Thu, Oct 04, 2012 at 03:36:40PM +0100, Måns Rullgård wrote: >> Diego Biurrun <di...@biurrun.de> writes: >> > On Thu, Oct 04, 2012 at 03:30:17PM +0100, Måns Rullgård wrote: >> >> Diego Biurrun <di...@biurrun.de> writes: >> >> > On Thu, Oct 04, 2012 at 02:04:27PM +0100, Måns Rullgård wrote: >> >> >> Diego Biurrun <di...@biurrun.de> writes: >> >> >> > --- a/libavutil/x86/cpu.c >> >> >> > +++ b/libavutil/x86/cpu.c >> >> >> > @@ -96,15 +113,7 @@ int ff_get_cpu_flags_x86(void) >> >> >> > >> >> >> > #if ARCH_X86_32 >> >> >> > - x86_reg a, c; >> >> >> > - >> >> >> > - /* Check if CPUID is supported by attempting to toggle the ID >> >> >> > bit in >> >> >> > - * the EFLAGS register. */ >> >> >> > - get_eflags(a); >> >> >> > - set_eflags(a ^ 0x200000); >> >> >> > - get_eflags(c); >> >> >> > - >> >> >> > - if (a == c) >> >> >> > + if (!have_cpuid()) >> >> >> > return 0; /* CPUID not supported */ >> >> >> > #endif >> >> >> >> >> >> You could "#define have_cpuid() 1" for x86_64 and get rid of this #if. >> >> > >> >> > But I rely on have_cpuid to mean that I have either yasm or inline asm >> >> > available in 5/5. >> >> >> >> I thought you tested for "cpuid" there. >> > >> > No. >> >> Why not? > > Because there is no "cpuid" symbol that I could check for. The HAVE_CPUID > that I remove in 3/5 denotes the compiler intrinsic.
#define cpuid(index, eax, ebx, ecx, edx) ^^ what's that then? -- Måns Rullgård m...@mansr.com _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
