On 2012-11-26 02:31:10 +0100, Luca Barbato wrote: > On 11/26/2012 12:03 AM, Janne Grunau wrote: > > Although sample count and delta are in ISO 14496-12 specified as > > unsigned files exists were interpreting it as signed integer makes > > more sense (see mp4-negative-stts-problem.mp4). > > Fixes an assert caused by negative avg_frame_rate deduced from a > > negative duratoin computed in mov_read_stts() with the fuzzed sample > > sample.mp4_s201788. > > s/duratoin/duration
fixed locally > > --- > > libavformat/mov.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/libavformat/mov.c b/libavformat/mov.c > > index 35c07bd..8dbcc41 100644 > > --- a/libavformat/mov.c > > +++ b/libavformat/mov.c > > @@ -1672,7 +1672,7 @@ static int mov_read_stts(MOVContext *c, AVIOContext > > *pb, MOVAtom atom) > > sc->stts_data[i].count= sample_count; > > sc->stts_data[i].duration= sample_duration; > > > > - av_dlog(c->fc, "sample_count=%d, sample_duration=%d\n", > > + av_log(c->fc, AV_LOG_WARNING,"sample_count=%d, > > sample_duration=%d\n", > > sample_count, sample_duration); > > I'd add an if (sample_duration < 0 || sample_count < 0) and put an > avoption to be strict ISO 14496-12 compliant or Quicktime compliant. That hunk shouldn't have been in there. I'll resend it later without Janne _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
