On Wednesday, November 28, 2012, Sean McGovern <gsean...@gmail.com> wrote:
> On Wed, Nov 28, 2012 at 8:08 PM, Måns Rullgård <m...@mansr.com> wrote:
>> Sean McGovern <gsean...@gmail.com> writes:
>>
>>> Several of the options were incorrect for suncc.
>>> ---
>>>  configure | 8 +++++---
>>>  1 file changed, 5 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/configure b/configure
>>> index ca11a85..f094a32 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -2196,7 +2196,8 @@ suncc_flags(){
>>>              -fomit-frame-pointer) echo -xregs=frameptr    ;;
>>>              -fPIC)                echo -KPIC -xcode=pic32 ;;
>>>              -W*,*)                echo $flag              ;;
>>> -            -f*-*|-W*)                                    ;;
>>> +            -f*-*|-W*|-mimpure-text)                      ;;
>>> +            -shared)              echo -G                 ;;
>>>              *)                    echo $flag              ;;
>>>          esac
>>>      done
>>> @@ -2748,8 +2749,9 @@ case $target_os in
>>>          ;;
>>>      sunos)
>>>          AVSERVERLDFLAGS=""
>>> -        SHFLAGS='-shared -Wl,-h,$$(@F)'
>>> -        enabled x86 && SHFLAGS="-mimpure-text $SHFLAGS"
>>> +        SHFLAGS='-Wl,-h,$$(@F)'
>>> +        append SHFLAGS $($ldflags_filter -shared)
>>> +        enabled x86 && append SHFLAGS $($ldflags_filter -mimpure-text)
>>>          network_extralibs="-lsocket -lnsl"
>>>          add_cppflags -D__EXTENSIONS__ -D_XOPEN_SOURCE=600
>>>          # When using suncc to build, the Solaris linker will mark
>>> --
>>
>> I have an even better idea.  Drop the second hunk above and apply this
>> instead:
>>
>> diff --git a/configure b/configure
>> index 38f52b1..0c580e1c 100755
>> --- a/configure
>> +++ b/configure
>> @@ -3781,7 +3781,7 @@ LD_PATH=$LD_PATH
>>  DLLTOOL=$dlltool
>>  LDFLAGS=$LDFLAGS
>>  LDFLAGS-avserver=$AVSERVERLDFLAGS
>> -SHFLAGS=$SHFLAGS
>> +SHFLAGS=$($ldflags_filter $SHFLAGS)
>>  YASMFLAGS=$YASMFLAGS
>>  BUILDSUF=$build_suffix
>>  FULLNAME=$FULLNAME
>>
>>
>> --
>> Måns Rullgård
>> m...@mansr.com
>
> This didn't go so well... SHFLAGS now contains a very unwanted linebreak.

My bash-fu is not great, this seems to be due to string tokenization inside
the here-document. I can echo it with the same statement right above the
here-doc and no linebreak is present.

-- Sean McG.
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to