Hi, On Sat, Dec 15, 2012 at 2:20 PM, Diego Biurrun <di...@biurrun.de> wrote: > On Sat, Dec 15, 2012 at 09:46:02AM -0800, Ronald S. Bultje wrote: >> --- /dev/null >> +++ b/libavcodec/arm/videodsp_arm.S >> @@ -0,0 +1,33 @@ >> +@ >> +@ ARMv4 optimized DSP utils >> +@ Copyright (c) 2004 AGAWA Koji <i (AT) atty (DOT) jp> >> + >> +#include "config.h" >> +#include "libavutil/arm/asm.S" >> + >> +#if HAVE_ARMV5TE_EXTERNAL >> +function ff_prefetch_arm, export=1 >> + subs r2, r2, #1 >> + pld [r0] >> + add r0, r0, r1 >> + bne ff_prefetch_arm >> + bx lr >> +endfunc >> +#endif > > You continue playing fast and loose with copyright. This was written > by Mans, not by Koji Agawa. > > Many of the instances where you add your name to the top of files in > this patch are also rather dubious.
Which ones? I wrote all videodsp initialization code, and I wrote the x86 asm. I only see the ppc one as being dubious, where I did write the init code but not the prefetch, so possibly one name is missing, and perhaps the C code, which was written and touched by a bunch of people (I'm too lazy to look up who, feel free to fill it in for me). So my name is not misplaced anywhere, rather 1-2 names of other people may be missing here or there. The part where Mans' name is missing is because it's missing in the original source file also. I can hardly be blamed for that. Will fix though. Ronald _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
