On Thu, 4 Jul 2013 10:16:22 -0400, Sean McGovern <[email protected]>
wrote:
> ---
> libavfilter/pthread.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavfilter/pthread.c b/libavfilter/pthread.c
> index 374c1c3..95a276c 100644
> --- a/libavfilter/pthread.c
> +++ b/libavfilter/pthread.c
> @@ -144,7 +144,7 @@ static int thread_execute(AVFilterContext *ctx,
> action_func *func,
> return 0;
> }
>
> -static int thread_init(ThreadContext *c, int nb_threads)
> +static int _thread_init(ThreadContext *c, int nb_threads)
The ISO C standard reserves the leading underscore in identifiers for the
implementation (meaning the compiler and the run-time).
So strictly speaking, this patch violates the C standard.
> {
> int i, ret;
>
> @@ -207,7 +207,7 @@ int ff_graph_thread_init(AVFilterGraph *graph)
> if (!graph->internal->thread)
> return AVERROR(ENOMEM);
>
> - ret = thread_init(graph->internal->thread, graph->nb_threads);
> + ret = _thread_init(graph->internal->thread, graph->nb_threads);
> if (ret <= 1) {
> av_freep(&graph->internal->thread);
> graph->thread_type = 0;
--
Rémi Denis-Courmont
Sent from my collocated server
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
