On 2013-07-04 16:43, Rémi Denis-Courmont wrote:
On Thu, 4 Jul 2013 10:16:22 -0400, Sean McGovern <[email protected]>
wrote:
--- a/libavfilter/pthread.c
+++ b/libavfilter/pthread.c
@@ -144,7 +144,7 @@ static int thread_execute(AVFilterContext *ctx, action_func
*func,
-static int thread_init(ThreadContext *c, int nb_threads)
+static int _thread_init(ThreadContext *c, int nb_threads)
The ISO C standard reserves the leading underscore in identifiers for the
implementation (meaning the compiler and the run-time).
So strictly speaking, this patch violates the C standard.
Not quite, a single underscore is only reserved at the file level:
ISO/IEC 9899:1999 (E)
7.1.3 Reserved identifiers
— All identifiers that begin with an underscore and either an uppercase
letter or another underscore are always reserved for any use.
— All identifiers that begin with an underscore are always reserved for
use as identifiers with file scope in both the ordinary and tag name
spaces.
But I agree that leading underscores are best avoided altogether.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
