On Fri, 26 Jul 2013 11:36:47 +0200
Luca Barbato <[email protected]> wrote:

> On 26/07/13 01:39, Josh Allmann wrote:
> > From: Stefano Sabatini <[email protected]>
> > 
> > Signed-off-by: Josh Allmann <[email protected]>

> > +/**
> > + * Convenience macro, the return value should be used only directly in
> > + * function arguments but never stand-alone.
> > + */
> > +#define av_err2str(errnum) \
> > +    av_make_error_string((char[AV_ERROR_MAX_STRING_SIZE]){0}, 
> > AV_ERROR_MAX_STRING_SIZE, errnum)
> > +
> > +
> > +/**
> >   * @}
> >   */
> >  
> 
> Looks wrong in many ways. We can do w/out it IMHO.

It does seem to be valid C, though. More valid than av_freep() or
av_reallocp().

What is _really_ ugly is that av_strerror needs a buffer, instead of
returning a static string.
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to