On Mon, Sep 30, 2013 at 05:28:59PM +0200, Diego Biurrun wrote:
> On Thu, Sep 12, 2013 at 06:06:23PM +0000, Loren Merritt wrote:
> > On Wed, 11 Sep 2013, Hendrik Leppkes wrote:
> >
> > > From: Loren Merritt <pengv...@akuvian.org>
> > >
> > > Now RET checks whether it immediately follows a branch, so the programmer
> > > dosen't have to keep track of that condition.
> > > REP_RET is still needed manually when it's a branch target, but that's
> > > much rarer.
> >
> > > The implementation involves lots of spurious labels, but that's ok
> > > because we strip them.
> >
> > That's true of x264's buildsystem, but not libav yet. So import that patch
> > too:
>
> We dropped stripping executables a long time ago in e0be794.
>
> > --- a/configure
> > +++ b/configure
> > @@ -1973,6 +1973,7 @@ nm_default="nm -g"
> > pkg_config_default=pkg-config
> > ranlib="ranlib"
> > +strip="strip"
> > yasmexe="yasm"
> >
> > nogas=":"
> > @@ -2231,6 +2232,7 @@ cc_default="${cross_prefix}${cc_default}"
> > pkg_config_default="${cross_prefix}${pkg_config_default}"
> > ranlib="${cross_prefix}${ranlib}"
> > +strip="${cross_prefix}${strip}"
> >
> > sysinclude_default="${sysroot}/usr/include"
> > @@ -4140,6 +4142,7 @@ AR=$ar
> > AR_O=$ar_o
> > RANLIB=$ranlib
> > +STRIP=$strip
> > LN_S=$ln_s
> > CPPFLAGS=$CPPFLAGS
> > --- a/library.mak
> > +++ b/library.mak
> > @@ -25,6 +25,7 @@ $(SUBDIR)%-test.i: $(SUBDIR)%.c
> > $(SUBDIR)x86/%.o: $(SUBDIR)x86/%.asm
> > $(DEPYASM) $(YASMFLAGS) -I $(<D)/ -M -o $@ $< > $(@:.o=.d)
> > $(YASM) $(YASMFLAGS) -I $(<D)/ -o $@ $<
> > + -@ $(if $(STRIP), $(STRIP) -wN '..@*' $@)
>
> Not sure what you are trying to achieve with the if, $(STRIP) should
> always be set ...
>
> If we bring back stripping, we'll need the rest of the portability
> parts from e0be794 as well.
These comments were never addressed.
I did not review this patch in much detail because the whole set was
still up in the air and this looks like it would require a lot of
work in order to become acceptable.
Diego
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
