On Tue, Nov 26, 2013 at 11:05:07AM +0100, Vittorio Giovara wrote:
> --- a/Changelog
> +++ b/Changelog
> @@ -50,6 +50,7 @@ version 10:
> - VP9 decoder
> - support for decoding through VDPAU in avconv (the -hwaccel option)
> - codec level stereoscopic metadata handling
> +- new framepack filter
Why "new"? Was there an old framepack filter? Everything in this
list could be prefixed with "new".
> --- a/doc/filters.texi
> +++ b/doc/filters.texi
> @@ -1252,6 +1252,25 @@ frames with a negative PTS.
> +@item format
> +Desired framepacking format. Supported values are @var{2d} (default),
> +@var{sbs}, @var{sbsqnx}, @var{tab}, @var{lines}, @var{columns},
> @var{frameseq}, @var{check}.
> +See a detailed format descritpion in @file{libavutil/stereo3d.h}.
descri_pt_ion
> --- /dev/null
> +++ b/libavfilter/vf_framepack.c
> @@ -0,0 +1,487 @@
> +
> +static void pack_checkers_frame(FramepackContext *s, AVFrame *dst)
What do you mean by "checkers"? The game? Did you intend to use
"checkered"?
> +static int request_frame(AVFilterLink *outlink)
> +{
> + /* when both are EOF videos are fully processed */
> + if (retl == retr && retl == AVERROR_EOF)
> + return retl;
I think you need a comma after EOF, the comment reads confusing.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
