On 26.05.2015 16:41, Vittorio Giovara wrote:
> On Tue, May 26, 2015 at 3:24 PM, wm4 <nfx...@googlemail.com> wrote:
>> On Tue, 26 May 2015 14:24:38 +0100
>> Vittorio Giovara <vittorio.giov...@gmail.com> wrote:
>>> +int ffio_read_size(AVIOContext *s, unsigned char *buf, int size)
>>> +{
>>> + int ret = avio_read(s, buf, size);
>>> + if (ret != size)
>>> + return AVERROR_INVALIDDATA;
>>> + return ret;
>>> +}
>>> +
>>> int ffio_read_indirect(AVIOContext *s, unsigned char *buf, int size, const
>>> unsigned char **data)
>>> {
>>> if (s->buf_end - s->buf_ptr >= size && !s->write_flag) {
>>
>> The name of the function has the wrong color. Wouldn't ffio_read_full()
>> be a better name?
>
> yes...
> amended locally
It seems Luca accidentally pushed an old version of this patch.
The pushed version still has the ffio_read_size name and Luca's
comment about the error handling is also not addressed.
Best regards,
Andreas
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
