On Tue, Jul 04, 2017 at 10:57:41PM +0300, Martin Storsjö wrote:
> On Tue, 4 Jul 2017, wm4 wrote:
> >On Tue, 4 Jul 2017 22:18:21 +0300 Martin Storsjö <mar...@martin.st> wrote:
> >>--- a/libavutil/hwcontext_d3d11va.c
> >>+++ b/libavutil/hwcontext_d3d11va.c
> >>@@ -47,6 +47,13 @@
> >>
> >>+#ifdef WINAPI_FAMILY
> >>+#include <winapifamily.h>
> >>+#if !WINAPI_FAMILY_PARTITION(WINAPI_PARTITION_DESKTOP)
> >>+#define UWP
> >>+#endif
> >>+#endif
> >>+
> >>@@ -56,7 +63,7 @@ static PFN_D3D11_CREATE_DEVICE mD3D11CreateDevice;
> >>
> >> static av_cold void load_functions(void)
> >> {
> >>-#if HAVE_LOADLIBRARY
> >>+#ifndef UWP
> >> // We let these "leak" - this is fine, as unloading has no great
> >> benefit, and
> >
> >LGTM... though isn't "UWP" a bit too generic as an identifier?
>
> It's a little terse yeah, but it's at least only visible within this file
> (for now). Any better suggestions?
WINAPI_FAMILY_DESKTOP
WINAPI_DESKTOP
or something along those lines? Maybe with an FF_ prefix?
Diego
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
