On Fri, Sep 29, 2017 at 10:56:08PM -0300, James Almer wrote:
> --- a/configure
> +++ b/configure
> @@ -1039,8 +1039,15 @@ check_pkg_config(){
>      pkg_libs=$($pkg_config --libs $pkg_config_flags $pkg)
>      check_func_headers "$headers" "$funcs" $pkg_cflags $pkg_libs "$@" &&
>          enable $name &&
> -        add_cflags    "$pkg_cflags" &&
> -        eval $(sanitize_var_name ${name}_extralibs)="\$pkg_libs"
> +        set_sanitized "${name}_cflags"    $pkg_cflags &&
> +        set_sanitized "${name}_extralibs" $pkg_libs
> +}
> +
> +check_pkg_config(){
> +    log check_pkg_config "$@"
> +    pkg="${2%% *}"
> +    test_pkg_config "$@" || return
> +    add_cflags $(get_sanitized "${name}_cflags")
>  }

You're setting pkg, but using name. Of course that works because all
variables are global in this shell script, but it's not exactly pretty
nonetheless. I'll try to make up my mind which way I want to handle
the situation.

Diego
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to