On 10/3/2017 9:49 PM, Diego Biurrun wrote:
> On Fri, Sep 29, 2017 at 10:56:08PM -0300, James Almer wrote:
>> --- a/configure
>> +++ b/configure
>> @@ -1039,8 +1039,15 @@ check_pkg_config(){
>> pkg_libs=$($pkg_config --libs $pkg_config_flags $pkg)
>> check_func_headers "$headers" "$funcs" $pkg_cflags $pkg_libs "$@" &&
>> enable $name &&
>> - add_cflags "$pkg_cflags" &&
>> - eval $(sanitize_var_name ${name}_extralibs)="\$pkg_libs"
>> + set_sanitized "${name}_cflags" $pkg_cflags &&
>> + set_sanitized "${name}_extralibs" $pkg_libs
>> +}
>> +
>> +check_pkg_config(){
>> + log check_pkg_config "$@"
>> + pkg="${2%% *}"
>> + test_pkg_config "$@" || return
>> + add_cflags $(get_sanitized "${name}_cflags")
>> }
>
> You're setting pkg, but using name. Of course that works because all
> variables are global in this shell script, but it's not exactly pretty
> nonetheless.
Yes, it was a mistake i didn't notice since name is effectively set
globally as you said.
> I'll try to make up my mind which way I want to handle
> the situation.
Want me to send a new version replacing pkg="${2%% *}" with name="$1" as
i suggested in a previous reply?
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
