Rainer Gerhards writes: > The problem was that I originally had the caller define the instance > structure (well, kind of... ;)). I discovered this didn't work (I was > too much rsyslog-minded, especially in my assumptions), changed things > and forgot to re-test with the old interface. New patch attached, > replaces the old one. I have done some limited testing with rsyslog > itself. >
I've applied and checked in the suggested patch with a few minor modifications: 1) dbi.h is an autogenerated file, so I moved the changes into dbi.h.in 2) some drivers need access to the instance (see below), so I added the accessor dbi_driver_get_instance() I've adapted test_dbi.c in libdbi-drivers and checked both interfaces. It turned out that some drivers (ingres, sqlite, sqlite3) run dbi_conn_new() in order to access databases other than the one they're connected to. This works when using the old interface, but must fail when the plugin-safe interface is used instead. I've changed these calls to dbi_conn_new_r() which works ok with both interfaces. However, this means that we'll have to move at least to 0.9 because the next libdbi release won't work with 0.8.x drivers as soon as you use the plugin-safe interface. Both libdbi and libdbi-drivers currently call themselves 0.9.0-pre1. Once we move to a new major release, we should review the discussion about unifying the version numbers and the library versioning information, see this feature request: http://sourceforge.net/tracker/index.php?func=detail&aid=1578577&group_id=65979&atid=512948 This would finally get us to 1.0 for both libdbi and libdbi-drivers. Before doing so, I'd once again ask everyone to test the new interface with all OSes you can get hold of, and to speak up now if any other important changes are required. I'll update the Programmer's Manual and the Driver Manual in the next days to reflect the API changes. regards, Markus -- Markus Hoenicka [EMAIL PROTECTED] (Spam-protected email: replace the quadrupeds with "mhoenicka") http://www.mhoenicka.de ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ libdbi-users mailing list libdbi-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libdbi-users
