We free the "v2v_version" string with a wrong function, which may cause
a crash. The last patch fixes this problem. The first three patches work
toward eliminating shadowed identifiers, because shadowing impeded my
analysis of "v2v_version"'s life cycle.

Laszlo

Laszlo Ersek (4):
  miniexpect: upgrade to miniexpect with PR#1
  eliminate shadowing of global variables
  p2v-c.m4: elicit a stricter set of warnings from gcc
  ssh.c: fix crash in "v2v_version" lifecycle management

 gui.c                   | 48 ++++++++++----------
 main.c                  | 11 +++--
 miniexpect/miniexpect.c |  2 +-
 ssh.c                   | 18 ++++----
 m4/p2v-c.m4             |  2 +-
 miniexpect/README       | 23 ++++++----
 6 files changed, 56 insertions(+), 48 deletions(-)

_______________________________________________
Libguestfs mailing list
Libguestfs@redhat.com
https://listman.redhat.com/mailman/listinfo/libguestfs

Reply via email to