On 09/23/22 14:36, Laszlo Ersek wrote: > On 09/23/22 12:14, Laszlo Ersek wrote: >> On 09/23/22 11:54, Richard W.M. Jones wrote: > >>> (2) Should we drop Gtk2 support? I kept this around to allow virt-p2v >>> to be compiled on RHEL <= 6. RHEL 5 in particular needs Gtk 2.10, >>> which even for Gtk 2 is an old version. Those RHEL releases had >>> support for some old hardware, especially some old HP Smart Array >>> devices, which was dropped in newer RHEL, making it impossible to >>> convert physical machines using those devices. >>> >>> However the move to PCRE2 means that we can no longer compile on RHEL 6 >>> (RHEL 7 is still OK). Gtk2 itself went out of support in 2021 [0], >>> although that is not very relevant. >>> >>> If we had a customer who wanted support for the old devices, perhaps >>> it is better to look for a modern distro that still supports them and >>> would have Gtk 3, PCRE 2, etc. Perhaps Fedora or Debian. >> >> I'll look into removing gtk2 support from virt-p2v. > > Can I drop "contrib/build-p2v-iso.sh" altogether? > > I found this script by grepping the tree for "gtk2". We no longer seem > to be building the p2v ISO on RHEL (any major release), and on Fedora, I > don't use this script. I propose we remove it.
... For that matter, the entire contrib/ subdir appears obsolete. Laszlo _______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs
