On Wed, Sep 14, 2022 at 09:47:49AM +0800, Ming Lei wrote: > FYI, I plan to stabilize libublksrv's API in 1.0 release, which > shouldn't take long. > > And recently I did some API changes, so suggest you to update with > it in both nbdublk and libublksrv.
Just got around to looking at the changes and building the new Fedora package. It would be good to tag the current version with 'v1.0', ie: git tag -a v1.0 -m "Version 1.0" git push --tags Future version updates can be made by adjusting configure.ac, eg. changing [1.0] -> [1.1]: https://github.com/ming1/ubdsrv/blob/698c92c9d292903adae142a86d2fee10fce91850/configure.ac#L5 and tagging it again (eg 'v1.1'). ---- You made some breaking ABI changes. Because the package uses libtool there is a way to ensure that any future ABI changes will not break existing callers, by adjusting lib/Makefile.am -version-info: https://github.com/ming1/ubdsrv/blob/698c92c9d292903adae142a86d2fee10fce91850/lib/Makefile.am#L21 The rules for this are quite complicated: https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html (At the moment you do not need to do anything.) It is also possible to use libtool with version scripts to do backwards compatible ABI changes, but this topic is quite complicated to explain. If you want to read about it, start here: https://stackoverflow.com/questions/67940587/linux-shared-library-versioning-for-backwards-compatibility-using-libtool ---- Anyway I will do a new Fedora package with version 1.0, but please do the 'git tag' command above, thanks! Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org _______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs
