https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #2 from Michael Meeks <michael.me...@collabora.com> --- Hi there, > This is a method where deletion listener was being used. > It has been replaced by a VclPtr reference. > Please verify if I'm on the right track. > http://pastebin.com/aea0PSVf Looks lovely =) Then again if we did xWindow.clear() there is no need for the reset as well. > Build and unit-tests are fine with the above code. Did you try 'make check' ? well worth running that at the top level before and after. > But build gives a unit-test failed if I use > xWindow.disposeAndClear() Sure - that forcibly destroys the window - we don't want to do that ;-) > Also vcl/README.lifecycle was a real help. Glad you like it; that's why I wrote it =) > And do you have ScopedVclPtr in place of VclPtr in mind for the future? Well; we have such a thing, but the templates generally could use a fair bit of cleanup there. > I could also notice a lot of things left in the "What remains to be done ?" > section of the doc. Sure - this is one of them; great to have you on it - I suspect there is scope for a lot of nice, small patches in gerrit - separated by other commits - so we can bisect to them nicely =) Thanks ! Hi there, + xWindow.clear(); + xWindow.reset(); -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
