https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #6 from Dipankar Niranjan <dipankar1...@gmail.com> --- Hi, Thanks for the really helpful Code Review.. I hope I've learned from it while I was resubmitting the patches. So here they are: dndevis.cxx https://gerrit.libreoffice.org/21211 dialog.cxx https://gerrit.libreoffice.org/21212 https://gerrit.libreoffice.org/21215 event.cxx https://gerrit.libreoffice.org/21216 https://gerrit.libreoffice.org/21219 https://gerrit.libreoffice.org/21220 winproc.cxx https://gerrit.libreoffice.org/21221 https://gerrit.libreoffice.org/21223 https://gerrit.libreoffice.org/21224 https://gerrit.libreoffice.org/21226 https://gerrit.libreoffice.org/21227 https://gerrit.libreoffice.org/21228 In /core/vcl/source/window/winproc.cxx In line 2001 before commit: if ( pSVEvent->mbCall && !pSVEvent->maDelData.IsDead() ) I do not know how to remove usage of pSVEvent->maDelData.IsDead() pSVEvent->mpWindow and pSVEvent->mpInstanceRef both fail to build. This is because ImplHandleUserEvent() is a static method. It is called in line 2574 in winproc.cxx I would need some help with the above like I had previously mentioned. button.cxx https://gerrit.libreoffice.org/21230 lstbox.cxx https://gerrit.libreoffice.org/21231 dockwin.cxx Noticed a couple of empty methods at line 716 https://gerrit.libreoffice.org/21232 menu.cxx https://gerrit.libreoffice.org/21233 menufloatingwindow.cxx https://gerrit.libreoffice.org/21234 syswin.cxx https://gerrit.libreoffice.org/21235 toolbox.cxx https://gerrit.libreoffice.org/21236 toolbox2.cxx https://gerrit.libreoffice.org/21237 Provided these patches are correct, I would need some help with: 1)Line 413 of window2.cxx as it involves inheritance if I'm not wrong. 2)I've not touched svapp.cxx as it involves a constructor, a method and a destructor of ImplDelData. Thanks! -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
