https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #13 from Michael Meeks <michael.me...@collabora.com> --- Hi there, > In /core/vcl/source/window/winproc.cxx > In line 2001 before commit: > if ( pSVEvent->mbCall && !pSVEvent->maDelData.IsDead() ) > I do not know how to remove usage of pSVEvent->maDelData.IsDead() Oh ? so - what was associated with the maDelData ? - it rather depends on that really =) so I think we need to look at all of the calls that did an ImplAddDel on that member - and make sure we're checking them. > pSVEvent->mpWindow and pSVEvent->mpInstanceRef both fail to build. Oh ? why ? surely pSVEvent->mpWindow->IsDisposed() would work nicely. > This is because ImplHandleUserEvent() is a static method. > It is called in line 2574 in winproc.cxx Hmm ? the above question is unrelated to static-ness AFAICS. > Provided these patches are correct, I would need some help with: > 1)Line 413 of window2.cxx as it involves inheritance if I'm not wrong. Wow - that is horrible ! =) wow ... why do we bother casting to sal_uIntPtr there. So - in this case we need to update the methods to instead of using this awful sal_uIntPtr - instead passing a VclPtr<> around for the mpFocusWindow. Then we can rip out the ImplFocusDelData struct: another nice cleanup ! =) > 2)I've not touched svapp.cxx as it involves a constructor, a method and a > destructor of ImplDelData. When there are no other calls of ImplDelData - we will remove the class, and kill all these methods, along with the notification code in window =) You're getting there ... nice work ! =) -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
