oox/source/drawingml/fillproperties.cxx |    4 ++++
 1 file changed, 4 insertions(+)

New commits:
commit 5920bc2d1a624021a6f3eb42a56ce9b96b53a39f
Author:     Justin Luth <justin.l...@collabora.com>
AuthorDate: Tue Feb 27 08:23:44 2024 -0500
Commit:     Justin Luth <jl...@mail.com>
CommitDate: Tue Feb 27 19:50:57 2024 +0100

    address shortcoming: document why I avoided axials for transparency
    
    Hmm, I like to complain when other people
    don't comment on why certain situations are excluded,
    and yet I did the same thing here.
    
    Thanks vmiklos for pointing that out.
    
    Change-Id: I4c5ddeaeee078f036fc31149fc29bc6acb277ab3
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164040
    Tested-by: Jenkins
    Reviewed-by: Justin Luth <jl...@mail.com>

diff --git a/oox/source/drawingml/fillproperties.cxx 
b/oox/source/drawingml/fillproperties.cxx
index f24208722cb5..596e18f2176e 100644
--- a/oox/source/drawingml/fillproperties.cxx
+++ b/oox/source/drawingml/fillproperties.cxx
@@ -543,6 +543,10 @@ void FillProperties::pushToPropMap(ShapePropertyMap& 
rPropMap, const GraphicHelp
 
                     // convert DrawingML angle (in 1/60000 degrees) to API 
angle (in 1/10 degrees)
                     aGradient.SetAngle(Degree10(static_cast< sal_Int16 >( 
(8100 - (nDmlAngle / (PER_DEGREE / 10))) % 3600 )));
+
+                    // If this is symmetrical, set it as an axial gradient for 
better UI/export.
+                    // There were chart2 unit test failures when doing this to 
transparent gradients
+                    // so just avoid that case.
                     if (!bContainsTransparency)
                         aGradient.tryToConvertToAxial();
                 }

Reply via email to