Hello,

I'm tackling back to fdo#39632 [1]. But I have a question about current implementation. I started my work with checkdirectory.cxx[2] , which is called 2 times during a typical install.

I just added the two last message boxes defined there to check it is called. I created a non-empty file where it says the sSetupIniPath will be, but did not manage to trigger the directory non empty error, which seems weird. When converting handle of the should-have-been-found to string, I get a -1. looking at &data content, I get some rubbish - if convert from tchar to tstring is ok -, so file seems not found.

Moreover, even if we find the file, nothing is done, so this could be removed, no ?


Side question: is there a make target to just trigger the MSI generation, if I want to avoid the "build" one ?


Best regards



[1]:https://bugs.freedesktop.org/show_bug.cgi?id=39632
[2]:http://cgit.freedesktop.org/libreoffice/core/tree/setup_native/source/win32/customactions/shellextensions/checkdirectory.cxx
--
Mat M
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to