On 2012.05.03 11:55, Hans de Goede wrote: > IMHO the current libusbx-1.0.x behavior on windows is a bug and needs > to be fixed,
IMHO, not having hotplug in libusb(x) is a major bug, rather than a just another very desirable feature, that should be fixed ASAP. In terms of priority, besides critical bugs that pop out and need an immediate fix, that would be on the top of my list. > so this is not about needlessly adding new functionality > duplicating effort, it is about fixing a bug. Yes, I agree. Except I see it part of a larger bug that also need to be fixed. > My problem with aiming for a hotplug solution here, is that a stable > release of such a solution (ie of libusbx-2.0) will be a long time away. 2.0 is a long time away, but a usable -devel may not. The plan is of course to have a -devel that, while experimental, is as stable as possible and that people can use in their apps. > Where as a fix for just this issue can be done much quicker and added > to libusb-1.0.12. As I said I currently sit on the fence with regards to this patch. Obviously, I would very much prefer having you guys use hotplug, as it would help us validate our implementation, which would benefit others. Also, considering that you will have to remove the patch and switch to a hotplug solution sooner or later, it might be worth ensuring you still have your requirements filled when that happens. But if not having something quick is a major issue, I don't have a major problem integrating it (though I haven't really reviewed it yet). > I understand, the problem is that we need a solution for this in a relative > short amount of time What are your constraints there? > Hmm, reading further below I think I may have misunderstood things, if the > plan is to add hotplug to libusbx-1.0.x, and do a release of that in > a reasonable timeframe I can understand your POV even more then before. Actually, that wasn't really my plan, but if there's a vote to try for hp in 1.0, I'm really all for it, as the proposal was designed for 1.0 anyway. I'd have no problem moving hp before libusb0/libusbk support and other things. > Still we have a need to get a fix out soonish as we want to make available > a windows spice client with (limited, winusb only) usbredir support > soon-ish. soonish = ? > We can carry a patch to our windows libusbx copy for that if it is > temporary, still a review would be appreciated in case we're breaking > things > without realizing it. We might as well have it in mainline if you guys use it, as it could benefit others. I'll see what I can do for review... Regards, /Pete ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ libusbx-devel mailing list libusbx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libusbx-devel
