Pete Batard wrote: > On 6 May 2012 00:52, Peter Stuge <pe...@stuge.se> wrote: > > Please clarify in the commit message what was changed since my > > commit, and please mention the commit id in libusb.git. > > This is done in the subject. Thread ID was added. There's no need > for more.
Your proposed commit message says clearly what the commit adds to libusbx.git, but the difference between my work and yours is not clear while I am named as author with no mention of you, and that isn't really accurate. > As to the libusb commit ID: Given that libusb as libusbx are separate > projects, and that we haven't done so for previous commits we picked, You can start doing it anyway if it looks like a good idea. > I don't see much point. The point is to assist anyone who is interested in code origin. Your efforts to reference the origin of work in the past (be it bug reports or code or design advice) lead me to believe that we agree that this is a good idea. > > If you prefer, please feel free to make yourself author, as long > > as the libusb.git commit reference is there. > > May I remind you that you have no authority whatsoever over what > happens in libusbx. Sorry, but that's not true. I own my work which is part of libusb and libusbx. The license terms apply to that work, and both libusb and libusbx follow those terms of course, but I remain the author of my work with all that it entails including full ownership of my work, while you are restricted to the authority over my work which you are granted by the license terms. The same thing of course applies to your work, and everyone else's, in libusb, libusbx and all other projects. If you want to make it so that I really have no authority whatsoever in libusbx then I think the only way is to remove every line of code which I have authored, but note that I am absolutely not asking you to do so. Who owns the code does matter every now and then; a project comes to mind where this week someone wanted to change the license of a few files in order to add them to yet another project. The license could only be changed with agreement among all copyright holders to do so, and while I don't expect this to be a priority in either libusb or libusbx I think it's still a good idea to try to be consistently clear about authorship, even for smaller changes such as adding the thread id. You ought to have your name on the addition since you are the author and since it isn't a trivial change. I shouldn't be able to claim authorship on code you authored, but if the patch is committed as proposed then actually I can. If you don't care about that then of course I will be happy that you assign your copyright to me, and then you can ignore my request, but please confirm if that is indeed the case! Otherwise, I think that including in the commit message something like: [pbatard: Added thread id] is enough to indicate what you added, even without the libusb.git commit id - but as I mentioned, if you want to change the author to yourself then I don't mind that either if you include the libusb.git commit id in the commit message. > If you can find anything with regards to the license that requires > us to legally reference a git commit ID from changes we pick from > wherever, please point to it. A commit id is merely a common and convenient reference, but please suggest another way if you have a preference? Thanks! //Peter ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ libusbx-devel mailing list libusbx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libusbx-devel
